Opened 13 years ago

Closed 13 years ago

#913 closed Defect (Fixed)

URL detection too relaxed since [3383]

Reported by: gboudreau Owned by: timothy
Component: Colloquy (Mac) Version: 2.2 (Mac)
Severity: Normal Keywords: URL
Cc:

Description

"test:test" is considered an URL, but shouldn't.

Change History (10)

comment:1 Changed 13 years ago by gboudreau

I changed (?:)? to (?:) in trunk/Additions/NSAttributedStringMoreAdditions.m line 311 to fix it. Not sure why you made the optional.

comment:2 Changed 13 years ago by timothy

I made them optional for mailto: links and other non-hierarchal links. But this could be a problem...

comment:3 Changed 13 years ago by timothy

  • Summary changed from URL detection too relaxed since CS 3383 to URL detection too relaxed since [3383]

comment:4 Changed 13 years ago by akempgen

but now jabber links work, which is nice if someone uses that. they look like xmpp:screenname@aim.domain.com or xmpp:chatroom@aim.domain.com?join

comment:5 Changed 13 years ago by timothy

Is there are common case where test:test (or something) would happen in a room? If not, I think this change is good, since more URLs work like akempgen said.

comment:6 Changed 13 years ago by timothy

These are fixed in [3391].

comment:7 Changed 13 years ago by akempgen

from #webkit

[14:36] <> /svn/webkit/WebKit/WebCore/platform/qt/FrameQt.cpp:104
[14:42] <> /svn/webkit/WebKit/WebCore/bridge/EditorClient.h:57

FrameQt.cpp:104 and EditorClient.h:57 are highlighted as urls

comment:8 Changed 13 years ago by akempgen

http://www.weaverslave.ws/forum.69.html?ff[forum_id]=3&ff[thread_id]=99&ff[offset]=0

only the part up to "…?ff" is recognized, the [] brackets seem to breake it (same problem with {} too).

comment:9 Changed 13 years ago by akempgen

[21:46] <> Ichbuch:~/Desktop memowe$ wget

"Ichbuch:~/Desktop" is highlighted

also a problem: CSI:NY ;)

comment:10 Changed 13 years ago by timothy

  • Resolution set to fixed
  • Status changed from new to closed

Totally fixed in [3445]. We no longer allow non-hierarchal links like xmpp:screenname@aim.domain.com.

Note: See TracTickets for help on using tickets.