Ticket #913 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

URL detection too relaxed since [3383]

Reported by: gboudreau Assigned to: timothy
Priority: normal Component: Colloquy (GUI)
Version: Latest Nightly Severity: normal
Keywords: URL Cc:

Description

"test:test" is considered an URL, but shouldn't.

Attachments

perl1.png (18.8 kB) - added by akempgen on 11/13/06 10:02:47.
problem: perl syntax
perl2.png (13.1 kB) - added by akempgen on 11/13/06 10:05:03.
problem: hex stuff (i think)
cia.png (10.5 kB) - added by akempgen on 11/13/06 10:06:25.
problem: cia commit message containing a url, the colon is added by cia and not part of the link

Change History

11/12/06 11:34:55 changed by gboudreau

I changed (?://)? to (?://) in trunk/Additions/NSAttributedStringMoreAdditions.m line 311 to fix it. Not sure why you made the // optional.

11/12/06 14:24:54 changed by timothy

I made them optional for mailto: links and other non-hierarchal links. But this could be a problem...

11/12/06 14:28:50 changed by timothy

  • summary changed from URL detection too relaxed since CS 3383 to URL detection too relaxed since [3383].

11/12/06 14:30:21 changed by akempgen

but now jabber links work, which is nice if someone uses that. they look like xmpp:screenname@aim.domain.com or xmpp:chatroom@aim.domain.com?join

11/12/06 21:25:22 changed by timothy

Is there are common case where test:test (or something) would happen in a room? If not, I think this change is good, since more URLs work like akempgen said.

11/13/06 10:02:47 changed by akempgen

  • attachment perl1.png added.

problem: perl syntax

11/13/06 10:05:03 changed by akempgen

  • attachment perl2.png added.

problem: hex stuff (i think)

11/13/06 10:06:25 changed by akempgen

  • attachment cia.png added.

problem: cia commit message containing a url, the colon is added by cia and not part of the link

11/13/06 11:15:10 changed by timothy

These are fixed in [3391].

11/20/06 07:59:02 changed by akempgen

from #webkit 

[14:36] <> /svn/webkit/WebKit/WebCore/platform/qt/FrameQt.cpp:104
[14:42] <> /svn/webkit/WebKit/WebCore/bridge/EditorClient.h:57

FrameQt.cpp:104 and EditorClient.h:57 are highlighted as urls

11/20/06 08:39:03 changed by akempgen 

http://www.weaverslave.ws/forum.69.html?ff[forum_id]=3&ff[thread_id]=99&ff[offset]=0

only the part up to "…?ff" is recognized, the [] brackets seem to breake it (same problem with {} too).

11/20/06 14:54:10 changed by akempgen 

[21:46] <> Ichbuch:~/Desktop memowe$ wget

"Ichbuch:~/Desktop" is highlighted

also a problem: CSI:NY ;)

12/08/06 20:45:59 changed by timothy

  • status changed from new to closed.
  • resolution set to fixed.

Totally fixed in [3445]. We no longer allow non-hierarchal links like xmpp:screenname@aim.domain.com.