Opened 12 years ago

Last modified 3 years ago

#759 new Defect

Search Highlight is broken (was: Search results as red marks: fix flaws, perhaps replace entirely?)

Reported by: reklam@… Owned by: timothy
Component: Colloquy (Mac) Version: 2.1 (Mac)
Severity: Major Keywords: search highlight
Cc: grahamperrin, martin@…

Description

When you run a search in the search field at the top-right corner, the results are displayed as red marks in the scroll bar.

This is very non-obvious, though admittedly somewhat aesthetically pleasing. It has a lot of issues, outlined below. These issues should be solved, perhaps by a more conventional search method.

The current search is very unprecise. The red marks only guide you to the matching screenful - you still have to look through that screenful "manually" to find matches.

An additional issue is that the scrollbar "elevator" hides the red marks, so you don't see if the current screenful contains matches.

Furthermore, if the history is too short for a scrollbar, no marks appear at all.

Finally, results that are at the very bottom of the chat window (at my settings: results in the two bottom-most lines) don't have their marks appear at all, because the marks are so far down the scrollbar as to be hidden under chrome.

(Version 2.1 (3290) - was not listed in tracker.)

Change History (12)

comment:1 Changed 12 years ago by akempgen

  • Version changed from 2.0 (2D16) to Latest Nightly

comment:2 Changed 12 years ago by akempgen

  • Keywords highlight added
  • Summary changed from Search results as red marks: fix flaws, perhaps replace entirely? to Search Highlight is broken (was: Search results as red marks: fix flaws, perhaps replace entirely?)
  • Type changed from enhancement to defect

turns out that colloquy once did highlight the search result in the scrollback (see your style prefs, it has a setting for it) but its currently broken.

comment:3 Changed 10 years ago by JohnQ

  • priority changed from normal to high
  • Severity changed from normal to major
  • Version changed from Latest Nightly to Latest 2.1

Shouldn't this be higher priority and severity than "normal"?
This bug completely defeats the Search functionality, making it impractically difficult to use. It strikes me that such a crippling bug in such fundamental feature as search should get a bit more attention. Its been open for 2 years now...

comment:4 Changed 10 years ago by grahamperrin

  • Cc grahamperrin added

FWIW,
+1 to high priority and major severity

comment:5 Changed 10 years ago by grahamperrin

Highlight from http://colloquy.info/project/ticket/109#comment:2

for long standing UI issues some out of the box thinking may be beneficial

— my twopenneth.

comment:6 Changed 9 years ago by martinreddy

  • Cc martin@… added

Is there any update on when this might get fixed? I've been using Colloquy for many months now and this is the only thing that really bugs me - to the point of looking for another IRC client. Having the search word highlighted in the text would be sooooo helpful for finding who has been asking you questions while you were away.

comment:7 Changed 6 years ago by Lance <lord.of.the.flies.0@…>

Is there any workaround or code modification for this on 2.3 (4617)? It still appears to be broken.

comment:8 Changed 5 years ago by anonymous

Holy fuck! STILL BROKEN?!

comment:9 Changed 3 years ago by anonymous

Yep, still broken.

comment:10 Changed 3 years ago by anonymous

And... search is still a no-op.

comment:11 Changed 3 years ago by anonymous

Should note for completeness sake that's in 2.4.3 (6011).

comment:12 Changed 3 years ago by anonymous

seriously this bug open for 9 years - this is pathetic off to another client what a joke...

Note: See TracTickets for help on using tickets.