Opened 7 years ago

Last modified 6 years ago

#3222 reopened Defect

VoiceOver fixes

Reported by: Boris Dušek <dusek@…> Owned by: timothy
Component: Colloquy (Mac) Version: 2.3 (Mac)
Severity: Normal Keywords: accessibility voiceover osx


These patches implement some improvements to current Colloquy accessibility. Most notably:

  • you can now browse nicknames of chat room participants, as well as chat room names and new message count
  • you can learn whether you are connected to a server in connections table, and whether the server will be autoconnected

I think especially the first one is important.

Everything else are minor improvements - mostly labeling stuff that could be, after some time, learnt by a blind user to be used without labels (albeit uncomfortable). These are:

  • labels for chat rooms table and expand button in "Join Room" dialog
  • labels for the actions and favorites button under the chat rooms and participants list in chat window
  • connections table

I implemented some things in code which could better be done in Interface Builder (e.g. labeling both tables and the 3 buttons). But trying to edit a NIB in interface builder produced huge diff of other unrelated changes (like deleting/adding nibs like keyedobjects or similar, or adding/deleting big sections of the .nib XML text), so I was not sure such patches would be OK. (I was using Xcode 4.3.3, now using 4.4). Also the idea of having to set the same accessibility title elements over again in all localized nibs freaked me out. Advice/suggestions welcome :-) - if I find a way to work with NIBs, I could improve many more small things.

Change History (7)

comment:1 follow-up: Changed 7 years ago by zach

  • Resolution set to Invalid
  • Status changed from new to closed

Unfortunately, the patch was lost during a Trac migration. If you see this, can you please reopen this ticket and repost this awesome sounding patch? Thanks!

comment:2 in reply to: ↑ 1 Changed 7 years ago by Boris Dušek <dusek@…>

  • Resolution Invalid deleted
  • Status changed from closed to reopened

I would love to, but I can't see a way to make any attachments to this ticket unfortunately :-( (Trying to register yields "Eror: Not Found. No handler matched request to /project/register" and my old password and login with username 'dusek' do not work when clicking "Login")

comment:3 Changed 7 years ago by zach

We had to reset most of our db a few months ago, so user accounts were lost (along with attachments) :\

If you make a new user and still can't log in, you can email the attachment to me (zach@…) and I'll re-attach it to the ticket (and more than likely, commit the changes to svn). Sorry for the inconvenience, and thank you *so* much for this!

comment:4 Changed 7 years ago by Boris Dušek <dusek@…>

Hello Zach, I just sent you and email with the patches (trying to register still yields the same error as I described 3 days ago).

I (over)split the patches into 7 patches to make review/rejecting easier. In case you find it more convenient to apply a single patch, I also provided such a patch (named 'VoiceOver?-fixes-improvements.patch') which is simply "sum" of the 7 patches.

Thanks in advance for reviewing and hopefully committing!

comment:5 Changed 7 years ago by zach

Committed in r5776. Thank you again for the patches, and for going through all the trouble to make sure they got committed!

comment:6 Changed 7 years ago by zach

  • Resolution set to Fixed
  • Status changed from reopened to closed

comment:7 Changed 6 years ago by me@…

  • Resolution Fixed deleted
  • Status changed from closed to reopened

Hello Zach, I sent you an email because on patch from the set actually did not get applied, so I resent it.

Note: See TracTickets for help on using tickets.