Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#1971 closed Defect (Invalid)

Mobile Colloquy does not support znc partyline module

Reported by: Kyle Fuller <inbox@…> Owned by: timothy
Component: Chat Core (IRC) Version: 2.2 (Mac)
Severity: Minor Keywords:
Cc:

Description

Whenever you try to join a channel in znc partyline, Colloquy appends # to it, so you cannot connect.

A solution could be adding ~ to the chatRoomNamePrefixes in MVIRCChatConnection.m

Before:

- (NSCharacterSet *) chatRoomNamePrefixes {
	static NSCharacterSet *defaultPrefixes = nil;
	if( ! _roomPrefixes && ! defaultPrefixes )
		defaultPrefixes = [[NSCharacterSet characterSetWithCharactersInString:@"#&+!"] retain];
	if( ! _roomPrefixes ) return defaultPrefixes;
	return _roomPrefixes;
}

After:

- (NSCharacterSet *) chatRoomNamePrefixes {
	static NSCharacterSet *defaultPrefixes = nil;
	if( ! _roomPrefixes && ! defaultPrefixes )
		defaultPrefixes = [[NSCharacterSet characterSetWithCharactersInString:@"#&+!~"] retain];
	if( ! _roomPrefixes ) return defaultPrefixes;
	return _roomPrefixes;
}

http://en.znc.in/wiki/Partyline

Change History (4)

comment:1 Changed 10 years ago by timothy

  • Component changed from Colloquy (Mobile) to Chat Core (IRC)
  • Owner changed from kiji.roshi to timothy
  • Version changed from 1.1 (Mobile) to Latest Nightly

Those are the default prefixes. If the server or Znc sends a 005 numeric with CHANTYPES=#~ that will be used instead and no change on our side is needed.

Maybe partyline can send a 005 numeric on connect?

comment:2 Changed 10 years ago by timothy

  • milestone changed from Mobile Colloquy 1.2 to Colloquy 2.4

comment:3 Changed 9 years ago by zach

  • Resolution set to invalid
  • Status changed from new to closed

This should be fixed by ZNC, not Colloquy.

comment:4 Changed 9 years ago by rob-to86

  • milestone Colloquy 2.4 deleted
Note: See TracTickets for help on using tickets.