Opened 11 years ago

Closed 11 years ago

#1722 closed Defect (Fixed)

New "Show Notices:" popup doesn't respect user's previous preference

Reported by: lapcat Owned by: akempgen
Component: Colloquy (Mac) Version: Local Build
Severity: Normal Keywords:
Cc:

Description

In svn r4408, the "Show Notices as Private Chat" checkbox in Interface preferences was replaced by a "Show Notices" popup with three options, "All", "Auto", and "None". In JVInterfacePreferences.nib, those three options have the tags 1, 0, and -1 respectively. The value of this popup is bound to the user default JVChatAlwaysShowNotices. However, previously this same user default represented a boolean value, where 0 meant that "Show Notices as Private Chat" was off. This would be the same behavior as "None" in the new popup, but 0 represents "Auto" rather than "None" in the new popup.

To respect the user's previous preference setting, the "None" option should have the tag 0 rather than the "Auto" option. Also, to handle this change in the nib, the integer values of JVChatAlwaysShowNotices at JVChatController.m:588 would need to be switched.

Change History (2)

comment:1 Changed 11 years ago by akempgen

  • Owner changed from timothy to akempgen
  • Status changed from new to accepted

comment:2 Changed 11 years ago by akempgen

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [4616].

Note: See TracTickets for help on using tickets.