Ticket #1386 (closed Defect: fixed)

Opened 14 months ago

Last modified 14 months ago

Allowing plugins to add/change message attributes broken in r3879

Reported by: hennk Owned by: timothy
Priority: Normal Milestone: Colloquy 2.3
Component: Chat Core (IRC) Version: 2.2 (Mac)
Severity: Normal Keywords:
Cc:

Description

r3589 let plugins add/change attributes of incoming messages (for example to notify upper layers of decryption results, like it's used in the FiSHy blowfish plugin).

r3879 broke this. I will attach a patch later which restores that functionality.

Attachments

mutable_message_attributes.patch (3.7 KB) - added by hennk 14 months ago.

Change History

Changed 14 months ago by hennk

Changed 14 months ago by hennk

Here is the patch. It directly creates mutable dictionaries in _handlePrivmsgWithParameters:fromSender:, _handleNoticeWithParameters:fromSender: and _sendMessage::::::, so no mutableCopies are necessary, as was the case in r3589.

Changed 14 months ago by timothy

  • status changed from new to closed
  • resolution set to fixed

Landed in [4169]. Thanks for the patch!

Changed 14 months ago by timothy

  • milestone set to Colloquy 2.3
Note: See TracTickets for help on using tickets.