Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1386 closed Defect (Fixed)

Allowing plugins to add/change message attributes broken in r3879

Reported by: hennk Owned by: timothy
Component: Chat Core (IRC) Version: 2.2 (Mac)
Severity: Normal Keywords:
Cc:

Description

r3589 let plugins add/change attributes of incoming messages (for example to notify upper layers of decryption results, like it's used in the FiSHy blowfish plugin).

r3879 broke this. I will attach a patch later which restores that functionality.

Change History (3)

comment:1 Changed 10 years ago by hennk

Here is the patch. It directly creates mutable dictionaries in _handlePrivmsgWithParameters:fromSender:, _handleNoticeWithParameters:fromSender: and _sendMessage::::::, so no mutableCopies are necessary, as was the case in r3589.

comment:2 Changed 10 years ago by timothy

  • Resolution set to fixed
  • Status changed from new to closed

Landed in [4169]. Thanks for the patch!

comment:3 Changed 10 years ago by timothy

  • milestone set to Colloquy 2.3
Note: See TracTickets for help on using tickets.