Ticket #1240 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

Colloquy sends malformed DCC SEND requests.

Reported by: nox Assigned to: timothy
Priority: normal Component: Chat Core (File Transfer)
Version: Built Source Severity: normal
Keywords: Cc:

Description

When you try to send a file to someone using one of the two most popular IRC clients (namely mIRC and Xchat), it fails and the client replies that your DCC SEND request.

Colloquy seems to add an extra parameter "T" to every DCC SEND request.

Here is a patch to fix this behaviour.

Attachments

Colloquy-malformed-dcc-send.diff (3.0 kB) - added by nox on 05/17/08 07:07:44.

Change History

05/17/08 07:07:44 changed by nox

  • attachment Colloquy-malformed-dcc-send.diff added.

05/28/08 17:57:27 changed by ScottMac

The format is known as Turbo DCC, you add T to the end of the handshake, if anything a space is missing from a few of those places but that's all. I also think that mIRC doesn't support it but it should still work as normal and ignore the T.

http://www.visualirc.net/tech-tdcc.php

06/01/08 00:39:33 changed by timothy

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [3783].

06/01/08 00:40:15 changed by timothy

ScottMac? was correct, this is the Turbo DCC feature. We just had some missing spaces. This should make other clients work again.