Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#1134 closed Defect (Fixed)

Use correct source list style on Leopard

Reported by: eschaton Owned by: timothy
Component: Colloquy (Mac) Version: 2.2 (Mac)
Severity: Normal Keywords:
Cc:

Description

Colloquy draws its own light-blue source list at the left of the window. On Leopard, it should just set the highlight style of the outline view to source list, which will change both the way the selection highlight is drawn and the way the background is drawn to match the operating system's standard source list style.

Change History (9)

comment:1 Changed 11 years ago by eschaton

This is very straightforward: JVSideOutlineView should just invoke super's methods instead of its custom drawing code when running on an OS later than 10.4 and instances of super's class respond to the method's selector. JVChatWindowController will also need to use -[NSTableView setTableHighlightStyle:] to make the chats outline use source list style when running on an OS later than 10.4.

I've tested this out building against the 10.5 SDK, but I suspect Colloquy wouldn't want to just take that change and require everyone building it to use Xcode 3.0 or later at this point. (Though let me know if you would!)

comment:2 Changed 11 years ago by eschaton

The attachment Colloquy-1134.patch will have Colloquy use Leopard source lists when run on Leopard, but not change which SDKs it builds against or its behavior on pre-Leopard operating systems.

comment:3 Changed 11 years ago by timothy

  • Status changed from new to assigned

This patch looks good. I am going to apply it and test it out before landing it.

comment:4 Changed 11 years ago by eschaton

I'll attached a better patch now. It minimizes the diffs, doesn't have a bogus -instancesRespondToSelector:, and doesn't use a magic constant (it just declares the constant that you would get if you were building with the 10.5 SDK). It'll be in Colloquy-1134-take2.patch.

comment:5 Changed 11 years ago by timothy

This is a much cleaner patch.

comment:6 Changed 11 years ago by timothy

I landed the second patch with some minor code style changes in [3777].

There are some spacing issues when using the new source list mode that I will look into fixing now.

  • The member icons are too far to the left, and the text does not line up with the room name like it use too.
  • The members are closer together vertically. They need a couple of pixels of space or something.

comment:7 Changed 10 years ago by timothy

  • Resolution set to fixed
  • Status changed from assigned to closed

Finished the 2 remaining issues in [3993].

comment:8 Changed 10 years ago by Robby

  • milestone set to Colloquy 2.2

comment:9 Changed 10 years ago by Robby

  • priority changed from Highest to High
Note: See TracTickets for help on using tickets.