Opened 11 years ago

Closed 11 years ago

#1080 closed Defect (Fixed)

Colloquy built from svn rev 3710 crashes on launch

Reported by: eschaton Owned by: timothy
Component: Chat Core (XMPP/Jabber) Version: Local Build
Severity: Blocker Keywords:
Cc:

Description

Colloquy as built from svn rev 3710 (HEAD as of this report) crashes on launch in Acid's +initialize? method. This is because there are a few transposed characters resulting in C strings where there should be constant NSStrings. With the below fix it works fine.

Index: Frameworks/Acid/jabber/JabberSubscriptionRequest.m
===================================================================
--- Frameworks/Acid/jabber/JabberSubscriptionRequest.m	(revision 3710)
+++ Frameworks/Acid/jabber/JabberSubscriptionRequest.m	(working copy)
@@ -56,9 +56,9 @@
     QRY_MESSAGE = [[XPathQuery alloc] initWithPath:@"/presence/status"];
     PRESSUBTYPE = [[NSDictionary alloc] initWithObjectsAndKeys:
                    [NSNumber numberWithLong:JSUBSCRIBE], @"subscribe",
-                   [NSNumber numberWithLong:JSUBSCRIBED], "@subscribed",
-                   [NSNumber numberWithLong:JUNSUBSCRIBE], "@unsubscribed",
-                   [NSNumber numberWithLong:JUNSUBSCRIBED], "@unsubscribed", nil];
+                   [NSNumber numberWithLong:JSUBSCRIBED], @"subscribed",
+                   [NSNumber numberWithLong:JUNSUBSCRIBE], @"unsubscribed",
+                   [NSNumber numberWithLong:JUNSUBSCRIBED], @"unsubscribed", nil];
 }
 
 -(id) initWithRecipient:(JabberID*)jid

Change History (1)

comment:1 Changed 11 years ago by timothy

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [3711].

Note: See TracTickets for help on using tickets.