Show
Ignore:
Timestamp:
07/18/08 17:42:24 (4 months ago)
Author:
timothy
Message:

Fix the real leaks found by the clang static analyzer. #1260

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/Controllers/MVBuddyListController.m

    r3607 r3794  
    331331 
    332332        [buddy addWatchRule:rule]; 
     333        [rule release]; 
    333334 
    334335        [self addBuddy:buddy]; 
     336        [buddy release]; 
     337 
    335338        [self save]; 
    336339 

  • trunk/Controllers/MVConnectionsController.m

    r3763 r3794  
    3737#pragma mark - 
    3838 
    39 @interface NSDisclosureButtonCell 
     39@interface NSDisclosureButtonCell : NSCell 
    4040+ (id) alloc; 
    4141- (id) initWithCell:(NSCell *) cell; 
    …… 
    214214        [toolbar setAutosavesConfiguration:YES]; 
    215215        [[self window] setToolbar:toolbar]; 
    216          
    217         [showDetails setCell:[[NSDisclosureButtonCell alloc] initWithCell:[showDetails cell]]]; 
     216 
     217        NSDisclosureButtonCell *cell = [[NSDisclosureButtonCell alloc] initWithCell:[showDetails cell]]; 
     218        [showDetails setCell:cell]; 
     219        [cell release]; 
    218220 
    219221        [self setWindowFrameAutosaveName:@"Connections"]; 

  • trunk/Controllers/MVCrashCatcher.m

    r3763 r3794  
    66        if( [[NSBundle bundleWithIdentifier:@"com.unsanity.smartcrashreports"] isLoaded] ) 
    77                return; // user has Unsanity Smart Crash Reports installed, don't use our own reporter 
    8         [[MVCrashCatcher alloc] init]; 
     8        [[MVCrashCatcher alloc] init]; // Released when the window is closed. 
    99} 
    1010