Changeset 3558

Show
Ignore:
Timestamp:
01/17/07 00:55:20 (2 years ago)
Author:
timothy
Message:

Fixes a potential security exploit (and crash) when someone invites you to a room with special characters.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/Controllers/JVChatController.m

    r3539 r3558  
    517517        [[JVNotificationController defaultController] performNotification:@"JVChatRoomInvite" withContextInfo:context]; 
    518518 
    519         if( NSRunInformationalAlertPanel( title, message, NSLocalizedString( @"Join", "join button" ), NSLocalizedString( @"Decline", "decline button" ), nil ) == NSOKButton ) 
     519        if( NSRunInformationalAlertPanel( title, @"%@", NSLocalizedString( @"Join", "join button" ), NSLocalizedString( @"Decline", "decline button" ), nil, message ) == NSOKButton ) 
    520520                [connection joinChatRoomNamed:room]; 
    521521} 
     
    535535        [[JVNotificationController defaultController] performNotification:@"JVDirectChatInvite" withContextInfo:context]; 
    536536 
    537         if( NSRunInformationalAlertPanel( title, message, NSLocalizedString( @"Accept", "accept button" ), NSLocalizedString( @"Decline", "decline button" ), nil ) == NSOKButton ) { 
     537        if( NSRunInformationalAlertPanel( title, @"%@", NSLocalizedString( @"Accept", "accept button" ), NSLocalizedString( @"Decline", "decline button" ), nil, message ) == NSOKButton ) { 
    538538                [self chatViewControllerForDirectChatConnection:connection ifExists:NO userInitiated:NO]; 
    539539                [connection initiate];